Skip to content

Mediaconch policy updates and adding mp4 tests #1010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dericed wants to merge 8 commits into
base: main
Choose a base branch
from
+132 −16
Open

Mediaconch policy updates and adding mp4 tests #1010

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
3a0f224
remove redundant rule
dericed Aug 25, 2026
1976d53
brackets
dericed Aug 25, 2026
c970b19
mediaconch report management updates
dericed Aug 25, 2026
9602ed4
add test for file truncation
dericed Aug 25, 2026
0497f2f
add truncation test for access mp4 as well
dericed Aug 25, 2026
27ecda6
reposition a few policies
dericed Aug 25, 2026
df4de5d
fix a description so it applies for all tests
dericed Aug 25, 2026
2c11cb6
add mediaconch tests for the access mp4
dericed Aug 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
148 changes: 132 additions & 16 deletions vrecord
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2003,10 +2003,12 @@ _lookup_choice(){

# audio codec
"24-bit PCM")
_add_mediaconch_rule_set "${AUDIO_CODEC_PCM_TEST}"
MIDDLEOPTIONS_PRES+=(-c:a pcm_s24le)
MIDDLEOPTIONS_PRES+=(-rf64 auto)
AUDIO_EXT='wav' ;;
"24-bit FLAC")
_add_mediaconch_rule_set "${AUDIO_CODEC_FLAC_TEST}"
MIDDLEOPTIONS_PRES+=(-c:a flac)
MIDDLEOPTIONS_PRES+=(-sample_fmt s32)
MIDDLEOPTIONS_PRES+=(-bits_per_raw_sample:a 24)
Expand Down Expand Up @@ -2808,7 +2810,6 @@ CONTAINER_MATROSKA_TEST='
'

CODEC_GENERAL_TEST='
<rule name="Is the video format YUV?" value="ColorSpace" tracktype="Video" operator="=">YUV</rule>
<rule name="Is the frame rate mode constant?" value="FrameRate_Mode" tracktype="Video" operator="=">CFR</rule>
<rule name="Is the color space YUV?" value="ColorSpace" tracktype="Video" operator="=">YUV</rule>
<policy type="or" name="Is the video bit depth 8 or 10?">
Expand Down Expand Up @@ -2895,6 +2896,52 @@ AUDIO_CODEC_FLAC_TEST='
<rule name="Bit Depth is 24?" value="BitDepth" tracktype="Audio" operator="=">24</rule>
</policy>
'

CONTAINER_MP4_TEST='
<rule name="Is the file extension mp4?" value="FileExtension" tracktype="General" operator="=">mp4</rule>
<rule name="Is the format MPEG-4?" value="Format" tracktype="General" operator="=">MPEG-4</rule>
<rule name="Is the format profile Base Media?" value="Format_Profile" tracktype="General" operator="=">Base Media</rule>
'

CODEC_H264_TEST='
<rule name="Is the video format H.264?" value="Format" tracktype="Video" operator="=">AVC</rule>
<rule name="Is the pixel format yuv420p?" value="ChromaSubsampling" tracktype="Video" operator="=">4:2:0</rule>
<rule name="Is the scan type progressive?" value="ScanType" tracktype="Video" operator="=">Progressive</rule>
<rule name="Is the frame rate mode constant?" value="FrameRate_Mode" tracktype="Video" operator="=">CFR</rule>
'

STANDARD_NTSC_ACCESS_DEINTERLACED_TEST='
<policy type="and" name="Is it NTSC?">
<rule name="Is the height 480?" value="Height" tracktype="Video" operator="=">480</rule>
<rule name="Is the width 720?" value="Width" tracktype="Video" operator="=">720</rule>
<rule name="Is the frame rate 29.970?" value="FrameRate" tracktype="Video" operator="=">29.970</rule>
<rule name="Is the scan type progressive?" value="ScanType" tracktype="Video" operator="=">Progressive</rule>
<rule name="Are the colour primaries BT.601 NTSC?" value="colour_primaries" tracktype="Video" operator="=">BT.601 NTSC</rule>
<rule name="Are the matrix coefficients BT.601?" value="matrix_coefficients" tracktype="Video" operator="=">BT.601</rule>
</policy>
'

STANDARD_PAL_ACCESS_DEINTERLACED_TEST='
<policy type="and" name="Is it PAL?">
<rule name="Is the height 576?" value="Height" tracktype="Video" operator="=">576</rule>
<rule name="Is the width 720?" value="Width" tracktype="Video" operator="=">720</rule>
<rule name="Is the frame rate 25.000?" value="FrameRate" tracktype="Video" operator="=">25.000</rule>
<rule name="Is the scan type progressive?" value="ScanType" tracktype="Video" operator="=">Progressive</rule>
<rule name="Are the colour primaries BT.601 PAL?" value="colour_primaries" tracktype="Video" operator="=">BT.601 PAL</rule>
<rule name="Are the matrix coefficients BT.601?" value="matrix_coefficients" tracktype="Video" operator="=">BT.601</rule>
</policy>
'

AUDIO_CODEC_AAC_TEST='
<rule name="Is the audio AAC?" value="Format" tracktype="Audio" operator="=">AAC</rule>
<policy type="or" name="1 or 2 channels of audio?">
<rule name="1 channel of audio?" value="Channels" tracktype="Audio" operator="=">1</rule>
<rule name="2 channels of audio?" value="Channels" tracktype="Audio" operator="=">2</rule>
</policy>
<rule name="Is the sample rate 48kHz?" value="SamplingRate" tracktype="Audio" operator="=">48000</rule>
'


# define mediaconch test fragment -end

_start_mediaconch_policy(){
Expand All @@ -2903,6 +2950,7 @@ cat <<MC_START > "${MEDIACONCH_POLICY_TMP}"
<?xml version="1.0"?>
<policy type="and" name="Check validity of a vrecord output">
<description>This policy tests FFV1 Matroska and Quicktime files made using vrecord and checks their validity</description>
<description>This policy tests video files made using vrecord and checks their validity against vrecord's specifications</description>
MC_START
}

Expand All @@ -2920,6 +2968,65 @@ _add_mediaconch_rule_set(){
fi
}

_check_access_mp4_mediaconch() {
if [[ "${MP4_CHOICE}" = "true" ]] && [[ -f "${MP4NAME}" ]] && "${MEDIACONCH_INSTALLED}" ; then
_report -d "Checking access MP4 conformance against a mediaconch policy..."
MP4_POLICY_TMP="$(_maketemp .mediaconch_mp4.xml)"
cat <<MC_MP4_START > "${MP4_POLICY_TMP}"
<?xml version="1.0"?>
<policy type="and" name="Check validity of a vrecord Access MP4 output">
<description>This policy tests the access MP4 file made using vrecord and checks its validity against vrecord's access specifications</description>
MC_MP4_START
echo "${CONTAINER_GENERAL_TEST}" >> "${MP4_POLICY_TMP}"
echo "${CONTAINER_MP4_TEST}" >> "${MP4_POLICY_TMP}"
echo "${CODEC_H264_TEST}" >> "${MP4_POLICY_TMP}"
if [[ "${STANDARD}" = "ntsc" ]] ; then
echo "${STANDARD_NTSC_ACCESS_DEINTERLACED_TEST}" >> "${MP4_POLICY_TMP}"
elif [[ "${STANDARD}" = "pal" ]] ; then
echo "${STANDARD_PAL_ACCESS_DEINTERLACED_TEST}" >> "${MP4_POLICY_TMP}"
fi
echo "${AUDIO_CODEC_AAC_TEST}" >> "${MP4_POLICY_TMP}"
cat <<MC_MP4_END >> "${MP4_POLICY_TMP}"
</policy>
<!-- ;) -->
MC_MP4_END
MP4_REPORT_TMP="$(_maketemp _mediaconch_mp4report.xml)"
MP4_REPORT="${DIR}/${FULL_OUTPUT_ID}_mp4_mediaconch_report.xml"
MP4_POLICY="${DIR}/${FULL_OUTPUT_ID}_mp4_mediaconch_policy.xml"
mediaconch -fx -p "${MP4_POLICY_TMP}" "${MP4NAME}" | xmlstarlet fo > "${MP4_REPORT_TMP}"
MP4_STATUS="$(xmlstarlet sel -N mc="https://mediaarea.net/mediaconch" -t -v mc:MediaConch/mc:media/mc:policy/@outcome -n "${MP4_REPORT_TMP}")"
if [[ "${MP4_STATUS}" = "pass" ]] ; then
_report -dt "Access MP4 passed policy check."
_writeingestlog "mediaconch_mp4_outcome" "passed"
elif [[ "${MP4_STATUS}" = "fail" ]] ; then
_report -wt "The access MP4 file did not pass vrecord policy check."
_mv_tmp_file "${MP4_REPORT_TMP}" "${MP4_REPORT}"
_mv_tmp_file "${MP4_POLICY_TMP}" "${MP4_POLICY}"
_writeingestlog "mediaconch_mp4_outcome" "failed ${MP4_POLICY}"
_report -wt "See ${MP4_REPORT} for a full MediaConch policy report."
_report -wt "Or review this attempt to summarize the issue:"
xmlstarlet edit -N "mc=https://mediaarea.net/mediaconch" -d "//*[@outcome='pass']" "${MP4_REPORT}" | xmlstarlet fo
else
_report -wt "Mediaconch ended in an unexpected way for the access MP4 (status: ${MP4_STATUS})."
_report -wt "${MP4_REPORT_TMP}:"
cat "${MP4_REPORT_TMP}"
_writeingestlog "mediaconch_mp4_outcome" "error ${MP4_STATUS}"
fi
fi
}

_check_file_truncation() {
TEST_FILE="${1}"
TEST_LABEL="${2}"
if [[ -f "${TEST_FILE}" ]] ; then
IS_TRUNCATED=$(mediainfo --Output=XML "${TEST_FILE}" | xmlstarlet sel -t -v "//*[local-name()='IsTruncated']" -n 2>/dev/null || echo "")
if [[ "${IS_TRUNCATED}" = "Yes" ]] ; then
cowsay "$(_report -w "WARNING: MediaInfo reports that the ${TEST_LABEL} file (${TEST_FILE}) may be truncated or incomplete.")"
fi
_writeingestlog "${TEST_LABEL}_truncated" "${IS_TRUNCATED}"
fi
}

_add_fadgi_header2vtt(){
VTT_FILE="${1}"
VTT_TYPE="${2}"
Expand Down Expand Up @@ -3144,11 +3251,6 @@ if [[ ! "${VIDEO_CODEC_CHOICE}" = "h264" ]] ; then
_add_mediaconch_rule_set "${CODEC_GENERAL_TEST}"
fi
_add_mediaconch_rule_set "${AUDIO_CODEC_GENERAL_TEST}"
if [[ "${AUDIO_CODEC_CHOICE}" = "24-bit PCM" ]] ; then
_add_mediaconch_rule_set "${AUDIO_CODEC_PCM_TEST}"
elif [[ "${AUDIO_CODEC_CHOICE}" = "24-bit FLAC" ]] ; then
_add_mediaconch_rule_set "${AUDIO_CODEC_FLAC_TEST}"
fi

# CLI passthrough and audiopassthrough modes
if [[ "${RUNTYPE}" = "passthrough" ]] ; then
Expand Down Expand Up @@ -3564,26 +3666,40 @@ if [[ "${DEVICE_INPUT_CHOICE}" = 0 ]] ; then
_writeingestlog "Decklink input buffer overrun" "Yes"
fi

# policy checks with mediaconch
if "$MEDIACONCH_INSTALLED" ; then
# mediaconch policy check on the preservation output
if "${MEDIACONCH_INSTALLED}" ; then
_report -d "Checking file conformance against a mediaconch policy..."
STATUS=$(mediaconch -fx -p "${MEDIACONCH_POLICY_TMP}" "${VRECORD_OUTPUT}" | xmlstarlet sel -N mc="https://mediaarea.net/mediaconch" -t -v mc:MediaConch/mc:media/mc:policy/@outcome -n)
MEDIACONCH_REPORT="${DIR}/${FULL_OUTPUT_ID}_mediaconch_report.xml"
MEDIACONCH_REPORT_TMP="$(_maketemp _mediaconch_report.xml)"
MEDIACONCH_POLICY="${DIR}/${FULL_OUTPUT_ID}_mediaconch_policy.xml"
mediaconch -fx -p "${MEDIACONCH_POLICY_TMP}" "${VRECORD_OUTPUT}" | xmlstarlet fo > "${MEDIACONCH_REPORT_TMP}"
STATUS="$(xmlstarlet sel -N mc="https://mediaarea.net/mediaconch" -t -v mc:MediaConch/mc:media/mc:policy/@outcome -n "${MEDIACONCH_REPORT_TMP}")"
if [[ "${STATUS}" = "pass" ]] ; then
_report -dt "File passed policy check for the video."
_writeingestlog "mediaconch_outcome" "passed"
elif [[ "${STATUS}" = "fail" ]] ; then
_report -wt "File did not pass vrecord policy check and may not conform to digital preservation standards."
mediaconch -fx -p "${MEDIACONCH_POLICY_TMP}" "${VRECORD_OUTPUT}" | xmlstarlet fo > "${DIR}/${FULL_OUTPUT_ID}_mediaconchreport.xml"
_mv_tmp_file "${MEDIACONCH_POLICY_TMP}" "${DIR}/${FULL_OUTPUT_ID}_mediaconch_policy.xml"
_writeingestlog "mediaconch_outcome" "failed ${DIR}/${FULL_OUTPUT_ID}_mediaconch_policy.xml"
_report -wt "See ${DIR}/${FULL_OUTPUT_ID}_mediaconchreport.xml for a full MediaConch policy report."
_mv_tmp_file "${MEDIACONCH_REPORT_TMP}" "${MEDIACONCH_REPORT}"
_mv_tmp_file "${MEDIACONCH_POLICY_TMP}" "${MEDIACONCH_POLICY}"
_writeingestlog "mediaconch_outcome" "failed ${MEDIACONCH_POLICY}"
_report -wt "See ${MEDIACONCH_REPORT} for a full MediaConch policy report."
_report -wt "Or review this attempt to summarize the issue:"
xmlstarlet edit -N "mc=https://mediaarea.net/mediaconch" -d "//*[@outcome='pass']" "${DIR}/${FULL_OUTPUT_ID}_mediaconchreport.xml"
xmlstarlet edit -N "mc=https://mediaarea.net/mediaconch" -d "//*[@outcome='pass']" "${MEDIACONCH_REPORT}" | xmlstarlet fo
else
_report -wt "Mediaconch ended in an unexpected way (${STATUS}). Here is its output."
mediaconch -p "${MEDIACONCH_POLICY_TMP}" "${VRECORD_OUTPUT}"
_report -wt "Mediaconch ended in an unexpected way (status: ${STATUS}). Here is its output."
_report -wt "${MEDIACONCH_REPORT}:"
cat "${MEDIACONCH_REPORT}"
_writeingestlog "mediaconch_outcome" "error ${STATUS}"
fi
fi
# mediaconch policy check on the access MP4
_check_access_mp4_mediaconch

# check file truncation
_check_file_truncation "${VRECORD_OUTPUT}" "preservation"
if [[ "${MP4_CHOICE}" = "true" ]] && [[ -f "${MP4NAME}" ]] ; then
_check_file_truncation "${MP4NAME}" "access_mp4"
fi

# embed logs in Matroska files
if "$MKVPROPEDIT_INSTALLED" ; then
Expand Down