Fix access mp4 framerate - #1011
Open
dericed wants to merge 9 commits into
Open
Conversation
otherwise framerate is doubled
Member
Author
|
this PR is based off #1010 |
iamdamosuzuki
approved these changes
Aug 25, 2026
iamdamosuzuki
left a comment
iamdamosuzuki
left a comment
Contributor
There was a problem hiding this comment.
Framerate now comes out at 29.97, so looks good. Still failing media conch because of color primaries and matrix coefficients because those fields are empty in the MP4. Maybe it's best to delete those rules in #1010 ?
privatezero
approved these changes
Aug 25, 2026
privatezero
left a comment
privatezero
left a comment
Member
There was a problem hiding this comment.
this seems to work on my end (tested with a file input, not live capture). I didn't have a problem with the matrix coefficients for the MP4 weirdly. I did have those failures when my output was set to AVI though (values are blank in the file)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.