Use particle color and radius attributes (#62) - #434
Merged
Merged
Conversation
added 3 commits
September 11, 2026 10:05
…ibutes # Conflicts: # src/modifiers/syncparticlesmodifier.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Particle colors and radii now reach drawing and GPU picking through instance attributes instead of texture lookups. Radii retain float32 precision instead of being quantized to 1/255. Styles follow persistent atom IDs when LAMMPS reorders instances, and position-only frames leave style buffers unchanged.
A small adapter wraps omovi's shader compilation and picking material. It checks the expected upstream shader expressions explicitly; future incompatible omovi updates must update this boundary. Selection highlighting keeps its existing path.
Closes #62.
Completed-run viewports bind attributes and restore styles from cached data when reopened, without waiting for a new timestep.
Validation: typecheck, 478 unit tests, production build, real-WebGL color pixels, off-center picking beyond the old texture radius, SSAO on/off plus camera movement, dynamic native radii, and reopening both atomic and bonded run-zero structures. Unit tests cover sparse IDs, reordering, precision, and avoiding unnecessary style-buffer updates. These checks establish the changed data path; they do not claim a hardware-independent FPS improvement.