Continue completed simulations into linked runs (#12) - #436
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A completed simulation can now continue from its live engine state for a chosen number of additional timesteps. The continuation gets a new linked run and preserves the parent's inputs and outputs. It copies the parent's input snapshot even if the working tree has changed, and retains the existing engine directory so open dumps and fixes continue correctly.
Continue is available only for the last completed simulation still loaded in this browser session. A saved full-sequence input recipe lets the continuation be replayed after reload. Invalid/stale continuation requests are rejected before allocating a run or resetting the engine.
Closes #12.
Validation: typecheck, 473 unit tests, production build, and a real-engine browser regression: a moving atom advances from step 10 to 30 (x=1.1 to x=1.3), the parent's trajectory stays byte-identical, and the full sequence replays after reload despite an invalid edit in the working tree. Store integration tests verify stale/invalid request guards, parent input preservation, and that continuation never calls engine start/reset.