Restore world-space ambient occlusion radius - #438
Merged
Merged
Conversation
The SSAO noise fix switched N8AO to a screen-pixel radius, where the 10-unit radius spans less than one atom and the pass degrades to a faint edge detector. On the diffusion example the effect looked absent. Keep the radius in simulation units so buried atoms stay dark at any zoom, and keep the detailed sampling that removes the grain the pixel mode was meant to hide. Ignore a persisted radius/intensity from the removed legacy slider so stale saved settings cannot change the look. The e2e spec now perturbs the radius mode before each settings change so it proves the reset rather than N8AO's default. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NMqBT1iPcu3ayt1QdXuWB1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ambient occlusion looked absent on the diffusion example. The earlier SSAO noise fix (#435) put N8AO in screen-pixel radius mode, where Atomify's radius of 10 spans less than one atom and the pass degrades to a faint edge detector. N8AO's AO-only debug view was almost pure white.
ssaoRadius/ssaoIntensityfrom the removed legacy slider, so a stale saved value cannot silently change the look now that the radius is honoured in world units.Validation
npm run typecheck, 485 unit tests,e2e/ssao-quality.spec.tspass.Follow-ups (out of scope)
🤖 Generated with Claude Code
https://claude.ai/code/session_01NMqBT1iPcu3ayt1QdXuWB1