Skip to content

Validate proof claims without leaking gateway responses#52

Merged
andreogle merged 1 commit into
andreogle:mainfrom
saviro-orin:fix/redact-proof-gateway-errors
Jul 10, 2026
Merged

Validate proof claims without leaking gateway responses#52
andreogle merged 1 commit into
andreogle:mainfrom
saviro-orin:fix/redact-proof-gateway-errors

Conversation

@saviro-orin

@saviro-orin saviro-orin commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Problem

Airnode accepted a proof after comparing only URL and method, even when the returned claim disagreed with requested headers, body, or response matchers. Non-OK gateway response bodies were also copied into errors and logs, where a gateway could echo upstream credentials.

Changes

  • compare requested headers, body, and response matchers against returned claim parameters
  • omit gateway response bodies from errors
  • add regression coverage for mismatched headers and secret-bearing gateway errors
  • document that proof gateways receive upstream credentials

Verification

  • bun run lint:prettier
  • bun run lint:eslint
  • bunx tsc --noEmit
  • bun run test:unit, 574 passed
  • book production build passed

@saviro-orin saviro-orin requested a review from andreogle as a code owner July 10, 2026 02:47
@saviro-orin saviro-orin force-pushed the fix/redact-proof-gateway-errors branch from 49f2d2b to a7842d0 Compare July 10, 2026 03:00
@saviro-orin saviro-orin force-pushed the fix/redact-proof-gateway-errors branch from a7842d0 to d6eea8a Compare July 10, 2026 20:37
@andreogle andreogle merged commit 5c71558 into andreogle:main Jul 10, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants