Skip to content

ci: exercise DDTest with action-installed tracer on Express - #1

Merged
anmarchenko merged 7 commits into
masterfrom
anmarchenko/ddtest-action-preload
Sep 30, 2026
Merged

anmarchenko merged 7 commits into
masterfrom
anmarchenko/ddtest-action-preload

Conversation

@anmarchenko

@anmarchenko anmarchenko commented Sep 30, 2026 •

Copy link
Copy Markdown
Owner

What

Run the real Express/Mocha project with the action-installed Datadog tracer and the latest published DDTest prerelease. Each run selects the newest published, non-draft prerelease by publication time, downloads its Linux amd64 binary and prints its version.

The DDTest action preload workflow verifies that dd-trace is outside the Express project, runs the full suite as a direct Mocha control, then plans and runs the Express tests through DDTest. The DDTest steps do not set NODE_OPTIONS: DDTest must resolve the tracer from the action's DD_TRACE_PACKAGE and add its preload. The direct Mocha control supplies its own preload.

Why

This PR originally reproduced a failure where DDTest could not resolve an action-installed tracer from the project. The workflow now checks the latest DDTest prerelease against the same real project. It follows published prereleases automatically.

The fixture sets DD_TRACE_ROUTER_ENABLED=false for direct Mocha and DDTest execution. Express's own tests assert that middleware and res.format receive the identical next function; dd-trace 6.16.0 wraps that function, causing failures even without DDTest. Only router instrumentation is disabled; Mocha test tracing and every Express test remain enabled. This run validates test tracing and DDTest execution, not router instrumentation.

E2E testing

Prerequisite: DD_API_KEY is configured as an Actions repository secret in anmarchenko/express.

  1. Push an update to this PR, rerun its DDTest action preload workflow, or dispatch the workflow from anmarchenko/ddtest-action-preload.
  2. Inspect Install latest DDTest prerelease in the job. Expect a successful download and the version reported by the newest published prerelease.
  3. Inspect Check the action preload is outside the project. Expect the action's absolute preload to resolve and project-local dd-trace/ci/init to remain unavailable.
  4. Expect the direct Mocha control, Plan Mocha tests with DDTest, and Run planned Mocha tests with DDTest to succeed. Confirm both direct and DDTest run logs contain the full passing Express suite, including res.format tests, with no failed tests.

The job runs on a disposable hosted runner; no fixture cleanup is needed. This PR targets the personal fork, not the upstream Express repository.

@coveralls

coveralls commented Sep 30, 2026 •

Copy link
Copy Markdown

Coverage Report for CI Build 36729207663

Warning

No base build found for commit 7ef9844 on master.
Coverage changes can't be calculated without a base build.
If a base build is processing, this comment will update automatically when it completes.

Coverage: 99.612%

Details

  • Patch coverage: No coverable lines changed in this PR.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

Requires a base build to compare against. How to fix this →


Coverage Stats

Coverage Status
Relevant Lines: 774
Covered Lines: 771
Line Coverage: 99.61%
Coverage Strength: 2600.83 hits per line

💛 - Coveralls

@anmarchenko
anmarchenko marked this pull request as ready for review September 30, 2026 14:22
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-30T14:28:29.304740Z 3f1b2cc Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3f1b2cc45c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/workflows/ddtest-action-preload.yml
@anmarchenko
anmarchenko merged commit b9133c9 into master Sep 30, 2026
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants