Repository navigation
ci: exercise DDTest with action-installed tracer on Express - #1
Conversation
Coverage Report for CI Build 36729207663Warning No base build found for commit Coverage: 99.612%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsRequires a base build to compare against. How to fix this → Coverage Stats
💛 - Coveralls |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3f1b2cc45c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
What
Run the real Express/Mocha project with the action-installed Datadog tracer and the latest published DDTest prerelease. Each run selects the newest published, non-draft prerelease by publication time, downloads its Linux amd64 binary and prints its version.
The DDTest action preload workflow verifies that
dd-traceis outside the Express project, runs the full suite as a direct Mocha control, then plans and runs the Express tests through DDTest. The DDTest steps do not setNODE_OPTIONS: DDTest must resolve the tracer from the action'sDD_TRACE_PACKAGEand add its preload. The direct Mocha control supplies its own preload.Why
This PR originally reproduced a failure where DDTest could not resolve an action-installed tracer from the project. The workflow now checks the latest DDTest prerelease against the same real project. It follows published prereleases automatically.
The fixture sets
DD_TRACE_ROUTER_ENABLED=falsefor direct Mocha and DDTest execution. Express's own tests assert that middleware andres.formatreceive the identicalnextfunction; dd-trace 6.16.0 wraps that function, causing failures even without DDTest. Only router instrumentation is disabled; Mocha test tracing and every Express test remain enabled. This run validates test tracing and DDTest execution, not router instrumentation.E2E testing
Prerequisite:
DD_API_KEYis configured as an Actions repository secret inanmarchenko/express.anmarchenko/ddtest-action-preload.dd-trace/ci/initto remain unavailable.res.formattests, with no failed tests.The job runs on a disposable hosted runner; no fixture cleanup is needed. This PR targets the personal fork, not the upstream Express repository.