build: use build-ci for benchmark merge-commit rebuild - #23
Closed
anonrig wants to merge 1 commit into
Closed
Conversation
The merge-commit job used `make -j4`, which skips configure. After node.gyp or generated sources change, that can leave the comparison binary unlinked against new files. `make build-ci` re-runs configure first, matching the base-build step. Assisted-by: Grok Signed-off-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: Yagiz Nizipli <anonrig@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The benchmark workflow’s merge-commit rebuild used
make -j4, which skips configure. Afternode.gypor generated sources change, that can leave the comparison binary unlinked against new files.This switches that step to
make build-ci -j4 V=1, matching the base-build job.Standalone CI fix; not part of nodejs#65273.