Skip to content

Reworked server percentage check to remove 1 TODO #6475

Open
Amemeda wants to merge 3 commits into
apache:mainfrom
Amemeda:todo
Open

Reworked server percentage check to remove 1 TODO #6475
Amemeda wants to merge 3 commits into
apache:mainfrom
Amemeda:todo

Conversation

@Amemeda

@Amemeda Amemeda commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Removing // TODO check < 100 from line 234 of ConfigurableScanServerSelector.java

  • if statement reworked to check server percentage instead of ratio, this way the TODO condition can be checked
  • Added third condition to the if to make sure the computed percent is not infinite
  • server ratio computation was moved into new else clause

@Amemeda

Amemeda commented Jul 15, 2026

Copy link
Copy Markdown
Contributor Author

Removes 1 TODO from #2699

@Amemeda Amemeda changed the title Reworked server percentage check, removes 1 TODO from apache#2699 Reworked server percentage check to remove 1 TODO Jul 15, 2026
@Amemeda

Amemeda commented Jul 15, 2026

Copy link
Copy Markdown
Contributor Author

Unsure if test for infinite double percent is needed, added it anyways, currently failing

@Amemeda Amemeda marked this pull request as ready for review July 15, 2026 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant