Repository navigation
refactor(rwlock): remove redundant unsafe trait impls - #357
Merged
Merged
Conversation
tisonkun
marked this pull request as ready for review
October 11, 2026 08:47
tisonkun
commented
Oct 11, 2026
Comment on lines
-76
to
-77
| unsafe impl<T: ?Sized + Send + Sync> Send for OwnedRwLockWriteGuard<T> {} | ||
| unsafe impl<T: ?Sized + Send + Sync> Sync for OwnedRwLockWriteGuard<T> {} |
Member
Author
There was a problem hiding this comment.
We have trait_tests.rs and compile_fail_tests to guard these traits.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove five redundant
unsafe impls from RwLock guards and let their access-token fields determine the sameSend/Syncbounds. Keep the borrowed read guard's explicitSendimplementation, which only requiresT: Sync.Clarify permit-release responsibility during borrowed token conversion and trim the RwLock modification notes in
LICENSE, retaining Tokio attribution and the existing license terms.Validation:
cargo x test(593 passed),cargo x check, andcargo x lint.