Repository navigation
test(oneshot): race receiver completion against the sender wake - #363
Merged
Merged
Conversation
tisonkun
marked this pull request as ready for review
October 11, 2026 10:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a regression test for the oneshot reclamation race fixed in #361. It registers the receiver's waker first so that sending or dropping the sender always takes the waking path, then completes and drops the receiver while the sender may still be inside that path. A single race rarely lands in the window between the final state swap and the helper's return, so the test repeats it 128 times under Miri.
With
asyncband/src/oneshotreverted to the code before #361, the existingoneshot_testpasses all 16 seeds in0..16under the CI Miri setup, while this test fails at 6 of them, including seeds 0 and 1 that CI runs. With the fix it passes all 16 and adds about 6 seconds per seed under Miri.