Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{
"comment": "Modify this file in a trivial way to cause this test suite to run.",
"modification": 5
"modification": 3
}
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,6 @@ def test_format_json_output_with_dict(self):
self.assertEqual(parsed['category'], 'test')
self.assertEqual(parsed['value'], 123)

@pytest.mark.uses_tft
def test_end_to_end_pipeline_local(self):
"""Integration test running the full pipeline locally."""
extra_opts = {
Expand Down Expand Up @@ -140,7 +139,6 @@ def test_end_to_end_pipeline_local(self):
self.assertIn('color', record)
self.assertIn('size', record)

@pytest.mark.uses_tft
def test_pipeline_with_missing_columns(self):
"""Test pipeline handles records with missing columns gracefully."""
# Create input with some missing columns
Expand Down
42 changes: 0 additions & 42 deletions sdks/python/apache_beam/testing/benchmarks/cloudml/constraints.txt

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -15,15 +15,12 @@
# limitations under the License.
#

# Core TFT dependencies with version bounds.
# Note: To avoid pip ResolutionTooDeep errors, always install using the constraints file:
# pip install -c constraints.txt -r requirements.txt
dill>=0.3,<0.5
tfx_bsl>=1.15,<1.17
tensorflow-transform>=1.15,<1.17
tensorflow>=2.15,<2.16
numpy>=1.22.0,<2.0
tensorflow-metadata>=1.15,<1.16
pyarrow>=10,<11
tensorflow-serving-api>=2.15,<2.16
tf-keras>=2.15,<2.16
dill==0.4.1
tfx_bsl==1.21.0
tensorflow-transform==1.21.0
tensorflow-metadata==1.21.0
tensorflow
numpy
pyarrow
tensorflow-serving-api
tf-keras
Comment on lines +22 to +26

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Leaving core dependencies like tensorflow, numpy, pyarrow, tensorflow-serving-api, and tf-keras completely unpinned or without version bounds can lead to non-reproducible environments and unexpected CI failures when new major/minor versions of these packages are released. Since tfx-bsl, tensorflow-transform, and tensorflow-metadata are pinned to 1.21.0, it is highly recommended to specify compatible version ranges or exact pins for their underlying dependencies (e.g., matching the TensorFlow and NumPy versions compatible with TFX 1.21.0) to ensure stability.

4 changes: 1 addition & 3 deletions sdks/python/test-suites/dataflow/common.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -573,9 +573,7 @@ task installTFTRequirements {
exec {
workingDir "$rootProject.projectDir/sdks/python/apache_beam/testing/benchmarks/cloudml/"
executable 'sh'
// Use constraints file to pin versions while allowing pip to
// resolve compatible versions within the specified ranges in requirements.txt
args '-c', ". ${envdir}/bin/activate && pip install -c constraints.txt -r requirements.txt"
args '-c', ". ${envdir}/bin/activate && pip install -r requirements.txt"
}
}
}
Expand Down
Loading