Conversation
…ailure Patch by Yifan Cai; Reviewed by TBD for CASSANALYTICS-196
bbotella
reviewed
Sep 11, 2026
| return false; | ||
| } | ||
|
|
||
| if (updateCount > 1) |
Contributor
There was a problem hiding this comment.
Can't we check this before we need to extract the tableId and the metadata? (just at line 638)
| { | ||
| JVMStabilityInspector.inspectThrowable(t); | ||
|
|
||
| if (failedMutationHasNoCdcTable(inputBuffer, size)) |
Contributor
There was a problem hiding this comment.
It is scary that this new behavior doesn't break a pre-existing test :-(
Comment on lines
+69
to
+70
| CassandraBridgeImplementation.setup(); | ||
| TableId unknownTableId = TableId.fromUUID(UUID.randomUUID()); |
Contributor
There was a problem hiding this comment.
nit: Maybe move these two to a helper getUnregisteredTable method?
| * when the table's metadata can't be found, or even the first {@link TableId} can't be read | ||
| */ | ||
| @VisibleForTesting | ||
| static boolean failedMutationHasNoCdcTable(byte[] inputBuffer, int size) |
Contributor
There was a problem hiding this comment.
Maybe it is just me, but I tend to not like the negative on method names. HasNo + false is what we are looking for here -> that double negative always messes my head :-P
What do you think on having a failedMutationHasCdcTable method instead that returns true if it needs to be handled, and false if it needs to be ignored?
Obviously not a blocker.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Patch by Yifan Cai; Reviewed by TBD for CASSANALYTICS-196