CASSANDRA-21623 Report the number of rows replica filtering protection cached when it warns - #5162
Open
AhmedReda85 wants to merge 1 commit into
Open
CASSANDRA-21623 Report the number of rows replica filtering protection cached when it warns#5162AhmedReda85 wants to merge 1 commit into
AhmedReda85 wants to merge 1 commit into
Conversation
… warns patch by Ahmed Reda; reviewed by <Reviewer> for CASSANDRA-21623
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Previously,
ReplicaFilteringProtectionemitted a warning immediately upon crossingcachedRowsWarnThreshold + 1, reporting the threshold value rather than the actual maximum number of rows cached during the query.This patch:
QueryMergeListener.close()so the peak cached count (maxRowsCached) across the entire query is reported."Replica filtering protection has cached up to %d rows during query %s, which is over the warning threshold of %d rows defined by 'cached_replica_rows_warn_threshold' in cassandra.yaml."cachedRowsFailThreshold(hitFailureThreshold = true).currentRowsCachedandcachedRowsFailThreshold.CHANGES.txtunder7.0.Jira
Testing
ReplicaFilteringProtectionTestusing AssertJ fluent assertions to verify the exact warning and failure messages.ant test-jvm-dtest-some -Dtest.name=org.apache.cassandra.distributed.test.ReplicaFilteringProtectionTest(BUILD SUCCESSFUL).git diff --checkwith zero whitespace errors.