[CELEBORN-2438][INFRA] Remove empty protected_branches in .asf.yaml - #3819
Closed
pan3793 wants to merge 1 commit into
Closed
[CELEBORN-2438][INFRA] Remove empty protected_branches in .asf.yaml#3819pan3793 wants to merge 1 commit into
pan3793 wants to merge 1 commit into
Conversation
Member
Author
|
It's a non-code change, I'm going to merge this and see what happens |
Member
Author
|
Merge Summary:
Posted by |
Member
Author
|
Seems to work as expected, asf infra stops complaining about errors on |
pan3793
added a commit
that referenced
this pull request
Aug 20, 2026
### What changes were proposed in this pull request? Remove the empty protected_branches key from `.asf.yaml`. ### Why are the changes needed? ASF infra validation rejects .asf.yaml because github.protected_branches expects a mapping, and the empty value fails schema parsing. Branch protection is already handled by github.rulesets, so the key is redundant. ### Does this PR resolve a correctness bug? - [ ] Yes ### Does this PR introduce _any_ user-facing change? - [ ] Yes ### How was this patch tested? Parsed .asf.yaml with a YAML parser to confirm it loads. Assisted-by: DeepSeek V4 Pro Closes #3819 from pan3793/CELEBORN-2438. Authored-by: Cheng Pan <chengpan@apache.org> Signed-off-by: Cheng Pan <chengpan@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Remove the empty protected_branches key from
.asf.yaml.Why are the changes needed?
ASF infra validation rejects .asf.yaml because github.protected_branches
expects a mapping, and the empty value fails schema parsing. Branch
protection is already handled by github.rulesets, so the key is redundant.
Does this PR resolve a correctness bug?
Does this PR introduce any user-facing change?
How was this patch tested?
Parsed .asf.yaml with a YAML parser to confirm it loads.
Assisted-by: DeepSeek V4 Pro