Skip to content

Name the parameter the RandomStringGenerator constructor actually takes - #771

Open
hxperl wants to merge 1 commit into
apache:masterfrom
hxperl:javadoc-randomstringgenerator-builder
Open

hxperl wants to merge 1 commit into
apache:masterfrom
hxperl:javadoc-randomstringgenerator-builder

Conversation

@hxperl

@hxperl hxperl commented Sep 15, 2026

Copy link
Copy Markdown

RandomStringGenerator's private constructor was changed to take a Builder, but the old five-parameter javadoc stayed on it. javadoc -Xdoclint:reference -private on master:

RandomStringGenerator.java:396: error: @param name not found
     * @param minimumCodePoint    smallest allowed code point (inclusive).

Five errors, all on this constructor, and the only doclint @param errors in the module. Replaced them with the parameter it takes.

The private constructor was changed to take a Builder, but the old
five-parameter javadoc stayed behind, so javadoc -Xdoclint:reference
-private reports five "@PARAM name not found" errors -- the only ones in
the module. Each of the five is already documented on the Builder setter
that sets it, so nothing is lost by replacing them with a single
"@PARAM builder", matching commons-io.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WZdW1VZpdhcpg3c5iFioSr
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant