fix: map() fails when keys are literals and values are column expressions#22784
Open
nathanb9 wants to merge 2 commits into
Open
fix: map() fails when keys are literals and values are column expressions#22784nathanb9 wants to merge 2 commits into
nathanb9 wants to merge 2 commits into
Conversation
github-actions
Bot
added
sqllogictest
Contributor
Author
|
CI failure seems like a transient docker failure |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #22781
Rationale for this change
map(['a','b'], [col, col * 10])fails at execution time with "map requires key and value lists to have the same length" when keys are all literals and values contain column references.Root cause: literal keys evaluate to
ColumnarValue::Scalar(FixedSizeList[N])(length N) while column values evaluate toColumnarValue::Array(length batch_size). The length check compares N != batch_size and errors.What changes are included in this PR?
In
make_map_batch: when one argument is scalar and the other is array, expand the scalar to matchbatch_sizeviaScalarValue::to_array_of_size(number_rows)before the length comparison.Are these changes tested?
Yes.
map.rsSELECT map(['a','b'], [column1, column1 * 10]) FROM (VALUES (1), (2), (3))Are there any user-facing changes?
No. Previously-failing queries now execute correctly.