branch-4.1: [fix](fe) Fix NereidsCoordinator not created in proxy flow due to missing parsedStatement on StatementContext #64363#64437
Open
github-actions[bot] wants to merge 1 commit into
Conversation
…sing parsedStatement on StatementContext (#64363) Problem Summary: In a multi-FE environment, when a CREATE TABLE AS SELECT with recursive CTE is forwarded from a follower FE to the master FE, the execution fails with "fragment has no children". Root Cause: In the proxy flow (ConnectProcessor.proxyExecute() → StmtExecutor(ConnectContext, OriginStatement, boolean)), the StatementContext is created fresh without a parsedStatement. When parseByNereids() later parses the SQL, it only sets this.parsedStmt on the StmtExecutor but did not propagate it to the ConnectContext's StatementContext. This caused SessionVariable.canUseNereidsDistributePlanner() to return false (because statementContext.getParsedStatement() instanceof LogicalPlanAdapter checked against null), which led to two consequences: NereidsPlanner.distribute() skipped generating Nereids distributed plans EnvFactory.createCoordinator() created a legacy Coordinator instead of NereidsCoordinator The legacy Coordinator cannot handle Nereids-planned fragments without distributed plans, resulting in "fragment has no children" at Coordinator.findMaxParallelFragmentIndex(). Fix: In StmtExecutor.parseByNereids(), after parsing the SQL, propagate the parsed statement to the ConnectContext's StatementContext via this.context.getStatementContext().setParsedStatement(parsedStmt). This ensures consistency with what downstream code (canUseNereidsDistributePlanner) reads.
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
|
run buildall |
Contributor
FE UT Coverage ReportIncrement line coverage |
Contributor
FE Regression Coverage ReportIncrement line coverage |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #64363