[branch-4.0](serde) fix split_by_delimiter missing backslash escape handling (#61995)#64438
Open
csun5285 wants to merge 1 commit into
Open
[branch-4.0](serde) fix split_by_delimiter missing backslash escape handling (#61995)#64438csun5285 wants to merge 1 commit into
csun5285 wants to merge 1 commit into
Conversation
…apache#61995) Manual backport of apache#61995 to branch-4.0. The serde util still lives under be/src/vec/data_types/serde/ on this branch (namespace doris::vectorized), so the core fix and the new UT are applied at the vec/ paths and the test's added include points to vec/data_types/serde/complex_type_deserialize_util.h. The core change, the UT body, and the jsonb regression data are unchanged. ### Bug Stream Load (JSON format) writing to Map<String, String> columns silently sets the column to NULL when the map value contains both \" (escaped quotes) and : or ,. Stream Load returns Success with FilteredRows=0 — data loss with no error indication. ### Fix Added \ escape skip in split_by_delimiter's character loop, before quote detection — consistent with the existing escape handling in deserialize_one_cell_from_json. (cherry picked from commit 0c9fff3) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
1 similar comment
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
2 similar comments
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
csun5285
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cherry picked from (#61995)