Skip to content

[fix](clone) When a tablet has some cooldown data, clone will fail#64443

Open
liutang123 wants to merge 1 commit into
apache:masterfrom
liutang123:fix-clone-cooldown-master
Open

[fix](clone) When a tablet has some cooldown data, clone will fail#64443
liutang123 wants to merge 1 commit into
apache:masterfrom
liutang123:fix-clone-cooldown-master

Conversation

@liutang123

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Bug behavior:

When some tablet contains cooldown rowsets and hot rowsets, clone will fail:

meet error status: [INTERNAL_ERROR]unexpected version. tablet version: -1, expected version: 4721

0# doris::EngineCloneTask::_set_tablet_info()

1# doris::EngineCloneTask::_do_clone()

2# doris::EngineCloneTask::execute()

3# doris::clone_callback(doris::StorageEngine&, doris::ClusterInfo const*, doris::TAgentTaskRequest const&)

4# doris::PriorTaskWorkerPool::normal_loop()

5# doris::Thread::supervise_thread(void*)

reproduce:

CREATE RESOURCE s3_resource

PROPERTIES

(

"type" = "s3",

"s3.endpoint" = "http://cos.ap-beijing.myqcloud.com/",

"s3.region" = "ap-beijing",

"s3.access_key" = "xx",

"s3.secret_key" = "xx",

"s3.root.path" = "/luciantest/cooldown_test/",

"s3.bucket" = "xxxxx-bj-yyyyy",

"use_path_style" = "false"

);

CREATE STORAGE POLICY cool_policy

PROPERTIES(

"storage_resource" = "s3_resource",

"cooldown_ttl" = "600"  

);

CREATE TABLE t1 (

id int

)

DISTRIBUTED BY HASH(id) BUCKETS 3

PROPERTIES (

"storage_policy" = "cool_policy",

"replication_num" = "1"

);

insert into test.t1 values(1779336512);

-- wait 10 minutes

alter table t1 set ("min_load_replica_num" = "1");

insert into test.t1 values(1779336512);

alter table t1 set ("replication_allocation" = "tag.location.default: 3"); -- trigger balance and clone

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants