fix: keep stale addresses refreshed on metadata failure (#16375) - #16423
Open
Anon2Tokyo wants to merge 1 commit into
Open
fix: keep stale addresses refreshed on metadata failure (#16375)#16423Anon2Tokyo wants to merge 1 commit into
Anon2Tokyo wants to merge 1 commit into
Conversation
Anon2Tokyo
marked this pull request as draft
August 13, 2026 15:44
Anon2Tokyo
force-pushed
the
issue-16375-k8s-nacos-stale-address
branch
from
August 13, 2026 15:46
2181c6b to
4abfff9
Compare
Anon2Tokyo
marked this pull request as ready for review
August 13, 2026 15:47
Anon2Tokyo
force-pushed
the
issue-16375-k8s-nacos-stale-address
branch
from
August 13, 2026 15:50
4abfff9 to
3c91d8b
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 3.3 #16423 +/- ##
============================================
- Coverage 60.87% 60.32% -0.56%
+ Complexity 11766 10261 -1505
============================================
Files 1953 1953
Lines 89273 89252 -21
Branches 13473 13389 -84
============================================
- Hits 54346 53837 -509
- Misses 29333 29737 +404
- Partials 5594 5678 +84
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change?
Fixes #16375
Fix stale provider addresses not being cleared when metadata lookup fails for all revisions in
ServiceInstancesChangedListener. The listener now continues through address notification so a later refresh can evict outdated URLs instead of keeping old Pod IPs around.Checklist