Skip to content

fix: keep stale addresses refreshed on metadata failure (#16375) - #16423

Open
Anon2Tokyo wants to merge 1 commit into
apache:3.3from
Anon2Tokyo:issue-16375-k8s-nacos-stale-address
Open

fix: keep stale addresses refreshed on metadata failure (#16375)#16423
Anon2Tokyo wants to merge 1 commit into
apache:3.3from
Anon2Tokyo:issue-16375-k8s-nacos-stale-address

Conversation

@Anon2Tokyo

@Anon2Tokyo Anon2Tokyo commented Aug 13, 2026

Copy link
Copy Markdown

What is the purpose of the change?
Fixes #16375

Fix stale provider addresses not being cleared when metadata lookup fails for all revisions in ServiceInstancesChangedListener. The listener now continues through address notification so a later refresh can evict outdated URLs instead of keeping old Pod IPs around.

Checklist

  • Make sure there is a GitHub_issue field for the change.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Make sure gitHub actions can pass. Why the workflow is failing and how to fix it?

@Anon2Tokyo
Anon2Tokyo marked this pull request as draft August 13, 2026 15:44
@Anon2Tokyo
Anon2Tokyo force-pushed the issue-16375-k8s-nacos-stale-address branch from 2181c6b to 4abfff9 Compare August 13, 2026 15:46
@Anon2Tokyo
Anon2Tokyo marked this pull request as ready for review August 13, 2026 15:47
@Anon2Tokyo
Anon2Tokyo force-pushed the issue-16375-k8s-nacos-stale-address branch from 4abfff9 to 3c91d8b Compare August 13, 2026 15:50
@codecov-commenter

codecov-commenter commented Aug 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.32%. Comparing base (3a30432) to head (3c91d8b).

Additional details and impacted files
@@             Coverage Diff              @@
##                3.3   #16423      +/-   ##
============================================
- Coverage     60.87%   60.32%   -0.56%     
+ Complexity    11766    10261    -1505     
============================================
  Files          1953     1953              
  Lines         89273    89252      -21     
  Branches      13473    13389      -84     
============================================
- Hits          54346    53837     -509     
- Misses        29333    29737     +404     
- Partials       5594     5678      +84     
Flag Coverage Δ
integration-tests-java21 ?
integration-tests-java8 ?
samples-tests-java21 32.16% <ø> (-0.04%) ⬇️
samples-tests-java8 29.83% <ø> (+0.03%) ⬆️
unit-tests-java11 ?
unit-tests-java17 58.59% <ø> (-0.05%) ⬇️
unit-tests-java21 58.59% <ø> (-0.02%) ⬇️
unit-tests-java25 ?
unit-tests-java8 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] k8s环境下还是会出现连接旧pod的ip

2 participants