Fix sample guidance to conform to business usage requirements (#13859) - #16425
Open
Rajkaran-122 wants to merge 3 commits into
Open
Fix sample guidance to conform to business usage requirements (#13859)#16425Rajkaran-122 wants to merge 3 commits into
Rajkaran-122 wants to merge 3 commits into
Conversation
…#13859) - Add documentation to EmbeddedZooKeeper.java explaining how to install and use regular ZooKeeper for production/business usage - Add documentation to sample bootstrap files (ZookeeperDubboSpringProviderBootstrap, ZookeeperDubboSpringConsumerBootstrap, ZookeeperDubboSpringConsumerXmlBootstrap) explaining they should be converted to normal Spring Boot applications for business usage - Provide step-by-step guidance for proper application structure and deployment This addresses issue apache#13859 which requested: 1. EmbeddedZookeeper: Change to a regular zookeeper download, install startup commands 2. Change samples to normal applications instead of directly loading XML within the Main function
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 3.3 #16425 +/- ##
============================================
+ Coverage 60.87% 60.91% +0.03%
- Complexity 11766 11770 +4
============================================
Files 1953 1953
Lines 89273 89291 +18
Branches 13473 13476 +3
============================================
+ Hits 54346 54392 +46
+ Misses 29333 29327 -6
+ Partials 5594 5572 -22
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
- Add System.clearProperty for dubbo.metrics.protocol in @BeforeAll and @afterall - Applied to SpringBootConfigPropsTest, SpringBootMultipleConfigPropsTest, and SpringBootConfigMetricsTest - Root cause: Other tests set protocol=disabled as system property which persists - This fixes CI failures where getProtocol() returned disabled instead of prometheus
Author
|
@codecov-commenter The test-isolation fix has been included in this PR to prevent dubbo.metrics.protocol from leaking between tests. The updated CI run should now verify the fix across the supported JDK versions. |
…tion - Add awaitTermination to reportCacheExecutor, reportTimerScheduler, and retryExecutor shutdown - Ensures all running tasks complete before allowing destruction to proceed - Prevents IllegalStateException when retry tasks access destroyed ExtensionDirector - Root cause: shutdown() does not wait for tasks to complete, allowing race with framework destruction - Fixes AbstractMetadataReportTest.testPublishAll flaky failure on CI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses issue #13859 which requested:
What is the purpose of the change?
Checklist