Restore default Triple async service methods - #16426
Open
skt-shinyruo wants to merge 1 commit into
Open
Conversation
Generated Triple service interfaces should not require providers to implement synthetic async methods. Restore the sync bridge while keeping the observer overload out of the interface. Fixes apache#13735
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## 3.3 #16426 +/- ##
=============================================
- Coverage 60.87% 36.90% -23.97%
+ Complexity 11766 11744 -22
=============================================
Files 1953 1952 -1
Lines 89273 89251 -22
Branches 13473 13389 -84
=============================================
- Hits 54346 32940 -21406
- Misses 29333 51728 +22395
+ Partials 5594 4583 -1011
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change?
Fixes #13735.
PR #13385 removed the unary observer overload from generated Triple service interfaces to avoid ambiguous method resolution. It also made the differently named async bridge abstract, which requires sync-only providers to implement a synthetic method that is not declared in their proto service.
This change restores the default async bridge while keeping the observer overload out of the interface. Providers that explicitly implement the async method continue to override it as before.
The regression test generates a unary service interface and compiles both a sync-only provider and a provider with an explicit async override. It also verifies that the observer overload removed by #13385 remains absent.
Verification
./mvnw -pl dubbo-plugin/dubbo-compiler test./mvnw -pl dubbo-plugin/dubbo-compiler -DskipTests packagegit diff --checkChecklist