Skip to content

refactor: reuse Head#field in ModelBuildEventListener field-assignment fallback - #1031

Merged
delei merged 4 commits into
apache:mainfrom
bengbengbalabalabeng:refactor-remove-redundant-reflection
Aug 24, 2026
Merged

refactor: reuse Head#field in ModelBuildEventListener field-assignment fallback#1031
delei merged 4 commits into
apache:mainfrom
bengbengbalabalabeng:refactor-remove-redundant-reflection

Conversation

@bengbengbalabalabeng

Copy link
Copy Markdown
Contributor

Purpose of the pull request

As title.

What's changed?

  • Replace the per-row getDeclaredField(fieldName) lookup with the Field already resolved on Head; the old lookup also missed superclass fields and silently dropped their values.
  • Wrap IllegalAccessException in ExcelDataConvertException with row/column context instead of a bare RuntimeException.

Checklist

  • I have read the Contributor Guide.
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

@delei delei left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@delei
delei merged commit a35624f into apache:main Aug 24, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants