Skip to content

[build] Exclude module-info.class from shaded fat-JARs #4046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Sekelenao wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −0
Open

[build] Exclude module-info.class from shaded fat-JARs #4046

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -886,6 +886,11 @@
<exclude>log4j2.properties</exclude>
<exclude>log4j-test.properties</exclude>
<exclude>log4j2-test.properties</exclude>
<!-- Do not copy module-info.class from shaded dependencies.
Otherwise, the shaded uber-JAR will inherit a third-party module descriptor (e.g. from commons-lang3)
which breaks JPMS modular consumption. -->
<exclude>module-info.class</exclude>
<exclude>META-INF/versions/**/module-info.class</exclude>
<!-- Do not copy the signatures in the META-INF folder.
Otherwise, this might cause SecurityExceptions when using the JAR. -->
<exclude>META-INF/*.SF</exclude>
Expand Down