[test] Wait for KV flush before limit scan - #4051
Merged
Merged
Conversation
Use acks=-1 so the limit scan assertion runs only after the asynchronous KV flush is visible in RocksDB. Co-Authored-By: Codex <noreply@openai.com> AI-Model: gpt-5.6-sol AI-Contributed/Feature: 0/0 AI-Contributed/UT: 3/3
wuchong
marked this pull request as ready for review
August 20, 2026 04:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #3877
ReplicaManagerTest#testLimitScanPrimaryKeyTablewrites a KV batch withacks=1and immediately scans RocksDB. Sinceacks=1only waits for the leader local log append, the scan can race with the asynchronous KV flush and observe the previous state.Brief change log
acks=-1in the limit scan test so the write completes only after the KV high watermark, which is bounded by the flushed RocksDB offset, has advanced.Tests
./mvnw -pl fluss-server -am -DskipITs -Dtest=ReplicaManagerTest#testLimitScanPrimaryKeyTable -Dsurefire.failIfNoSpecifiedTests=false testAPI and Format
No API or format changes.
Documentation
No documentation changes.
Generative AI disclosure