HBASE-30209 MobFileCleanerChore is not registered for online configur…#8341
Open
liuxiaocs7 wants to merge 2 commits into
Open
HBASE-30209 MobFileCleanerChore is not registered for online configur…#8341liuxiaocs7 wants to merge 2 commits into
liuxiaocs7 wants to merge 2 commits into
Conversation
apache#8324) Signed-off-by: Junegunn Choi <junegunn@apache.org> Reviewed-by: Vladimir Rodionov <vladrodionov@gmail.com>
liuxiaocs7
added
the
backport
There was a problem hiding this comment.
Pull request overview
This PR addresses HBASE-30209 by ensuring MobFileCleanerChore participates in HMaster’s online configuration update mechanism (via ConfigurationManager observers), and adds/extends tests to validate both scheduling and dynamic reconfiguration behavior.
Changes:
- Register
MobFileCleanerChoreas aConfigurationManagerobserver during HMaster initialization. - Add a unit test validating
MobFileCleanerChore.onConfigurationChangeresizes its executor thread pool. - Extend the “default scheduled chores” master test to assert the MOB cleaner chore is scheduled and registered as a configuration observer.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java | Registers MobFileCleanerChore with configurationManager so it receives online config updates. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/mob/TestMobFileCleanerChore.java | Adds a test verifying onConfigurationChange resizes the cleaner executor. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterChoreScheduled.java | Adds coverage to confirm the MOB cleaner chore is scheduled and intended to be registered for config updates. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…… (#8324)