fix(license): Add missing LICENSE and NOTICE symlinks for iceberg-cache-moka and iceberg-catalog-loader#2828
Merged
Merged
Conversation
…he-moka and iceberg-catalog-loader
Contributor
Author
|
@CTTY please can you review this one for RC4? |
CTTY
pushed a commit
that referenced
this pull request
Jul 14, 2026
…#2830) ## Which issue does this PR close? For release: #2527 ## What changes are included in this PR? These changes are cherry-picks of #2823 and #2828. The crates were missing the LICENSE and NOTICE files required for the distributed source code. ## Are these changes tested? Tested using the following script provided by @kevinjqliu. Introducing this in CI is left as a follow-up (#2827). ```bash set -Eeuo pipefail failed=0 while IFS= read -r crate; do echo "Checking ${crate}..." files="$(cargo package \ --package "${crate}" \ --list \ --locked)" for required in LICENSE NOTICE; do if ! grep -Fxq "${required}" <<<"${files}"; then echo "::error::${crate} package is missing top-level ${required}" failed=1 fi done done < <( cargo metadata --no-deps --format-version 1 | jq -r '.packages[] | select(.publish != []) | .name' ) exit "${failed}" ``` --------- Co-authored-by: Andrew Kane <andrew@ankane.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Follow-up from #2823.
What changes are included in this PR?
Add symlinks from the crate roots to the project root's LICENSE and NOTICE files.
Are these changes tested?
Tested using the following script provided by @kevinjqliu. Introducing this in CI is left as a follow-up (#2827).