Fix #327: evaluate merged model lists on Maven 3 - #416
Open
wilx wants to merge 2 commits into
Open
Conversation
wilx
marked this pull request as ready for review
August 9, 2026 13:35
Author
|
It looks like #419 is needed for the tests to pass. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #327 for the Maven 3 maintenance line.
help:evaluatecan receive model collections implemented by Maven's internalModelMerger.MergingList. XStream does not recognize that implementation as a collection and falls back to reflective serialization, which fails when it tries to accessAbstractList.modCounton recent JDKs.This change registers a collection converter that accepts every
Collectionimplementation and aliases the concrete runtime list class so the existing XML root name is preserved. The evaluated list is serialized directly without copying it.The commits are intentionally split: the first adds the regression IT and fails with the reflection error; the second applies the fix.
Validation
clean verify: all 22 unit tests passed-Prun-its clean verify: all 22 unit tests and all 35 ITs passed-Prun-its clean verify: the regression IT passed; 34 of 35 ITs passed, with the unrelated existingdescribe-cmdassertion failing because thedeploylifecycle mapping was reported as undefinedChecklist
This pull request addresses one issue without unrelated changes.
The description explains what changed, how, and why.
Each commit has a meaningful subject line and body. Commit subjects are meaningful; no commit bodies were added.
A regression integration test fails without the runtime change.
mvn verifywas run successfully.The complete integration-test suite was run successfully with Maven 3.9.16; the Maven 3.10.0-rc-1 boundary is documented above.
I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004.
In any other case, an Apache Individual Contributor License Agreement has been filed.