MINIFICPP-2845 - Monotonic provenance event identifiers, iterations support, refactor#2209
MINIFICPP-2845 - Monotonic provenance event identifiers, iterations support, refactor#2209adamdebreceni wants to merge 3 commits into
Conversation
| class SchedulingAgent { | ||
| public: | ||
| SchedulingAgent(const gsl::not_null<core::controller::ControllerServiceProvider*> controller_service_provider, std::shared_ptr<core::Repository> repo, std::shared_ptr<core::Repository> flow_repo, | ||
| SchedulingAgent(const gsl::not_null<core::controller::ControllerServiceProvider*> controller_service_provider, std::shared_ptr<provenance::ProvenanceRepository> repo, std::shared_ptr<core::Repository> flow_repo, |
There was a problem hiding this comment.
I believe the "repo" naming of identifiers that have to be provenance repo was a mistake. I'm glad the type makes it clearer now, but I'd change the parameter and member names too. provenance_repo or prov_repo seem like good options to me.
| Identifier& operator++(); | ||
| Identifier operator++(int); | ||
|
|
There was a problem hiding this comment.
why do we need these UUID increments? I believe the Identified class is not meant to represent integer auto-increment keys.
There was a problem hiding this comment.
currently the RocksDbProvenanceRepository uses the event_uuid for key, we could either bring back the retired SequentialIdGenerator, we could replace the increment operators with a next() method to not cause confusion, or we could use an uint64_t (event ordinal) as key, which one do you prefer?
Co-authored-by: Márton Szász <szaszm@apache.org>
a5b3ee2 to
af3f98a
Compare
2 participants
Depends on #2195
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically main)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.