{bp-3684} audioutils/lame: pin the checkout and build its AVX-512 sources - #3775
Merged
Conversation
The bundled encoder was checked out from lame's trunk with no revision, so every build took whatever trunk happened to be at that moment. lame's trunk grows vector tiers over time, and each one adds sources that the two build files have to name: r6655 offered AVX2 to the vector routines on 2026-07-25, and r6718 and r6720 added an AVX-512 tier on 2026-07-30. The AVX-512 sources were never listed, so sim:alsa stopped linking on x86 hosts: takehiro.c:332: undefined reference to `quantize_lines_xrpow_avx512' takehiro.c:533: undefined reference to `ix_max_avx512' takehiro.c:569: undefined reference to `count_bit_esc_avx512' vbrquantize.c:261: undefined reference to `calc_sfb_noise_x34_avx512' Pin the checkout to r6720 through a LAME_VERSION variable, as the rest of apps/ pins its third-party sources, and list the three AVX-512 files that revision provides. The pin is what keeps the two in step: the source list is maintained by hand, so it can only be correct for a known revision. The checkout is also only performed when lame/configure is absent and is never updated afterwards, so before this an unpinned tree was frozen at whatever trunk was on the day it was first built. Anyone who checked out before 2026-07-30 still links and cannot reproduce the failure, which is why this surfaced only in CI. Makefile named just vector/xmm_quantize_sub.c and none of the other vector sources, so a Make build on an x86 host fails the same way with a longer list of symbols, from SSE2 upwards. CI builds sim:alsa through CMake only, so that half was latent rather than visible. Both files now list the same nine sources under the same host condition. Signed-off-by: Marco Casaroli <marco.casaroli@gmail.com> Assisted-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
jerpelea
requested review from
acassis,
cederom,
linguini1 and
xiaoxiang781216
September 7, 2026 10:33
This was referenced Sep 7, 2026
{bp-19854} fs/vfs/fs_read.c: Allow NULL iov_base when CONFIG_ARCH_TEXT_VBASE == 0
apache/nuttx#20068
Merged
Merged
xiaoxiang781216
approved these changes
Sep 7, 2026
acassis
approved these changes
Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The bundled encoder was checked out from lame's trunk with no revision, so every build took whatever trunk happened to be at that moment. lame's trunk grows vector tiers over time, and each one adds sources that the two build files have to name: r6655 offered AVX2 to the vector routines on 2026-07-25, and r6718 and r6720 added an AVX-512 tier on 2026-07-30. The AVX-512 sources were never listed, so sim:alsa stopped linking on x86 hosts:
takehiro.c:332: undefined reference to
quantize_lines_xrpow_avx512' takehiro.c:533: undefined reference toix_max_avx512'takehiro.c:569: undefined reference to
count_bit_esc_avx512' vbrquantize.c:261: undefined reference tocalc_sfb_noise_x34_avx512'Pin the checkout to r6720 through a LAME_VERSION variable, as the rest of apps/ pins its third-party sources, and list the three AVX-512 files that revision provides. The pin is what keeps the two in step: the source list is maintained by hand, so it can only be correct for a known revision.
The checkout is also only performed when lame/configure is absent and is never updated afterwards, so before this an unpinned tree was frozen at whatever trunk was on the day it was first built. Anyone who checked out before 2026-07-30 still links and cannot reproduce the failure, which is why this surfaced only in CI.
Makefile named just vector/xmm_quantize_sub.c and none of the other vector sources, so a Make build on an x86 host fails the same way with a longer list of symbols, from SSE2 upwards. CI builds sim:alsa through CMake only, so that half was latent rather than visible. Both files now list the same nine sources under the same host condition.
Impact
RELEASE
Testing
CI