[OPENJPA-2981] Remove dead access-type helper methods - #154
Open
rzo1 wants to merge 1 commit into
Open
Conversation
Remove the private helpers hasMixedAnnotations(Class, OpenJPAConfiguration), hasFieldStrategyAnnotations(Class) and hasGetterStrategyAnnotations(Class) from PersistenceMetaDataDefaults. All three were private and had no callers anywhere in the code base. They were added in b537665 ("[OPENJPA-2940] Allow mixed FIELD+PROPERTY annotation placement without @access") as a draft shape of the mixed-annotation access resolution; the version that actually shipped in that commit was written inline in determineImplicitAccessType(...), so the helpers were unused from the moment they were introduced. Commit 58ffe9c ("[OPENJPA-2940] Fix AccessDefiningFilter for dual-annotated entities and mappedBy resolution") then rewrote that inline logic and removed the last live uses of the accessTypeFilter field, leaving its only remaining references inside the dead helpers. Consequently the accessTypeFilter field and the AccessTypeFilter nested filter class, which after that rework are reachable only from the removed methods, are dropped as well. No other member or import becomes unused. Raised in review of PR 144.
solomax
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the three private access-type helpers in
PersistenceMetaDataDefaultsthat never had a caller, plus theaccessTypeFilterfield andAccessTypeFilterclass that were only reachable from them.