HDDS-15827. Wait for SCM pipelines in TestDnRatisLogParser#10724
Closed
jojochuang wants to merge 1 commit into
Closed
HDDS-15827. Wait for SCM pipelines in TestDnRatisLogParser#10724jojochuang wants to merge 1 commit into
jojochuang wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR hardens the TestDnRatisLogParser integration test by waiting for SCM to report at least one pipeline before indexing getPipelines().get(0), addressing intermittent IndexOutOfBoundsException failures when pipeline creation lags behind cluster readiness.
Changes:
- Add a
GenericTestUtils.waitFor(...)gate to ensure SCM pipeline list is non-empty before accessing the first pipeline. - Reduce test flakiness in single-datanode mini-cluster runs where pipeline creation can be delayed.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jojochuang
changed the title
Co-authored-by: Cursor <cursoragent@cursor.com> Change-Id: I5849809e940c04cb6432a552f96ababa8db58251
jojochuang
force-pushed
the
HDDS-15822-fix-dn-ratis-log-parser-test
branch
from
2df421e to
2ee0593
Compare
jojochuang
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TestDnRatisLogParserreadsgetPipelines().get(0).IndexOutOfBoundsException: Index 0 out of bounds for length 0when pipeline creation lags behindwaitForClusterToBeReady().Jira
https://issues.apache.org/jira/browse/HDDS-15827
Problem
testRatisLogParsinguses a single-datanode mini-cluster and immediately indexes the first SCM pipeline. In CI, the pipeline list can still be empty when the test runs, even though the cluster is marked ready.Test plan
ozone-integration-testmodulemvn -pl :ozone-integration-test test -Dtest=TestDnRatisLogParser -DskipShade -DskipRecon -DskipDocs