HDDS-15804. Use Set instead of List for ACLs in OMKeyRequest.#10727
Open
szetszwo wants to merge 1 commit into
Open
HDDS-15804. Use Set instead of List for ACLs in OMKeyRequest.#10727szetszwo wants to merge 1 commit into
szetszwo wants to merge 1 commit into
Conversation
cchung100m
approved these changes
Jul 11, 2026
cchung100m
left a comment
cchung100m
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thanks to @szetszwo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
ACLs are supposed to be distinct. So, it is better to use a Set instead of a List. This JIRA is to change OMKeyRequest and also some other minor ACL improvements.
What is the link to the Apache JIRA
HDDS-15804
How was this patch tested?
By existing tests