Remove deprecated Attributes.getFirst/getFirstAttribute (since Akka 2.5.7)#3291
Closed
He-Pin wants to merge 1 commit into
Closed
Remove deprecated Attributes.getFirst/getFirstAttribute (since Akka 2.5.7)#3291He-Pin wants to merge 1 commit into
He-Pin wants to merge 1 commit into
Conversation
Member
|
This method is used - apache/pekko-http#470 |
He-Pin
force-pushed
the
remove/deprecated-attributes-getFirst
branch
from
July 5, 2026 06:13
cffd44d to
875d740
Compare
He-Pin
marked this pull request as ready for review
July 5, 2026 07:57
He-Pin
force-pushed
the
remove/deprecated-attributes-getFirst
branch
2 times, most recently
from
July 8, 2026 18:15
953de25 to
1617372
Compare
…nce Akka 2.5.7) Motivation: The getFirst and getFirstAttribute methods were deprecated since Akka 2.5.7 because attributes should always be accessed using the most-specific getter (get/getAttribute), not the least-specific getter. Modification: Remove the four deprecated methods: getFirstAttribute(Class, default), getFirstAttribute(Class), getFirst[T](default), getFirst[T]. Update tests to use the non-deprecated get/getAttribute methods. Remove tests that specifically tested getFirst behavior. Result: Only the most-specific attribute accessors (get/getAttribute) remain. Tests: Not run - deprecated API cleanup with test updates References: None - deprecated API cleanup
He-Pin
force-pushed
the
remove/deprecated-attributes-getFirst
branch
from
July 14, 2026 04:08
1617372 to
2c07833
Compare
Member
Author
|
This PR is blocked by a cross-project dependency:
I've requested @pjfanning to review pekko-http PR #470 to unblock this chain. |
Member
|
The pekko http pr is blocked. The link above is wrong. Why is it so important to remove this API that we actually need? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Attributes.getFirstandgetFirstAttributewere deprecated since Akka 2.5.7. The replacement API isgetandgetAttribute.Modification
Removed the following deprecated methods from
Attributes:getFirstAttribute(Class, default)- deprecated since Akka 2.5.7getFirstAttribute(Class)- deprecated since Akka 2.5.7getFirst[T](default)- deprecated since Akka 2.5.7getFirst[T]- deprecated since Akka 2.5.7Updated test files to use
getinstead ofgetFirst:AttributesSpec.scala: removedgetFirstassertionsSinkSpec.scala: changedgetFirsttoget, removed tests exclusively testinggetFirstBidiFlowSpec.scala: changedgetFirsttogetGraphDSLCompileSpec.scala: changedgetFirsttogetAttributesTest.java: removed test methods forgetFirstAttributeResult
Deprecated API removed. Users should use
getandgetAttributeinstead.Tests
Tests updated to use the replacement API.