RATIS-2596. Unsupported TLS cipher suites may crash gRPC servers#1510
Merged
Conversation
szetszwo
approved these changes
Jul 10, 2026
szetszwo
left a comment
szetszwo
left a comment
Contributor
There was a problem hiding this comment.
+1 the change looks good
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In case TLS ciphers are configurable, it is possible to configure ciphers that are not supported by Netty.
This patch changes the IdentityCipherSuiteFilter to the SupportedCipherSuiteFilter in GrpcUtil.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/RATIS-2596
How was this patch tested?
What is changing is tested functionality, the issue has appeared already elsewhere, I did not perform any particular tests as this exact changed worked well in the previous occurance (HDDS-15176).