fix(search): tolerate blank optional arguments and return safe errors - #195
Open
adityamparikh wants to merge 4 commits into
Open
fix(search): tolerate blank optional arguments and return safe errors#195adityamparikh wants to merge 4 commits into
adityamparikh wants to merge 4 commits into
Conversation
Signed-off-by: Aditya Parikh <aditya.m.parikh@gmail.com> Co-authored-by: Junie <junie@jetbrains.com>
Signed-off-by: Aditya Parikh <aditya.m.parikh@gmail.com> Co-authored-by: Junie <junie@jetbrains.com>
adityamparikh
added a commit
to adityamparikh/solr-mcp
that referenced
this pull request
Sep 11, 2026
Keep this PR indexing-only; move search usability changes to apache#195. Replace root-restricted JSON file ingestion with local STDIO multi-format ingestion without a file-size cap. Signed-off-by: Aditya Parikh <aditya.m.parikh@gmail.com> Co-authored-by: Junie <junie@jetbrains.com>
This was referenced Sep 11, 2026
The client only sees the generic message, so the log is the only record of the cause; DEBUG hid it in production. The schemaless-facet integration test exercised Solr's faceting rather than this change and was the sole reason for the untyped platform fixture field. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CiUHyyXLTo9ATdgg8eRFZJ Signed-off-by: Aditya Parikh <aditya.m.parikh@gmail.com>
The untyped platform fixture field went away with the schemaless-facet test, so the blank-options test now filters on platform_ss. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CiUHyyXLTo9ATdgg8eRFZJ Signed-off-by: Aditya Parikh <aditya.m.parikh@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
filterQueries,facetFieldsandsortClausesarguments are ignored; non-blank values and the validation of sort orders are unchanged.McpClientIntegrationTestBaserun over HTTP and STDIO.Verification
./gradlew buildon Java 25: 414 tests, 0 failures, 7 skipped (the OTLP suite, skipped onmainuntil #198). Unit, real-Solr and MCP HTTP/STDIO coverage. Native images and other Solr versions were not tested.🤖 Generated with Claude Code
https://claude.ai/code/session_01CiUHyyXLTo9ATdgg8eRFZJ