fix: narrow SchemaService.getSchema() throws clause - #98
Open
adityamparikh wants to merge 3 commits into
Open
Conversation
adityamparikh
force-pushed
the
fix/schema-service-throws-clause
branch
from
May 2, 2026 17:04
90997b8 to
84768e3
Compare
adityamparikh
force-pushed
the
fix/schema-service-throws-clause
branch
from
June 14, 2026 03:34
84768e3 to
2a0b152
Compare
Change getSchema() from `throws Exception` to `throws SolrServerException, IOException` to match the actual exceptions thrown by SchemaRequest.process(). Signed-off-by: Aditya Parikh <aditya.m.parikh@gmail.com> Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: adityamparikh <aditya.m.parikh@gmail.com>
adityamparikh
force-pushed
the
fix/schema-service-throws-clause
branch
from
August 19, 2026 11:58
2a0b152 to
f9e8326
Compare
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CiUHyyXLTo9ATdgg8eRFZJ Signed-off-by: Aditya Parikh <aditya.m.parikh@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getSchema()fromthrows Exceptiontothrows SolrServerException, IOException, the exceptionsSchemaRequest.process()declares. Source-compatible for callers.SolrServerException; it surfaces as an uncheckedSolrException(404), whichSchemaServiceIntegrationTestalready covers.Verification
./gradlew buildon Java 25: 403 tests, 0 failures, 7 skipped (the OTLP suite, skipped onmainuntil test(observability): re-enable OtlpExportIntegrationTest #198).Touches the same
SchemaService.getSchemalines as #108; whichever merges second needs a one-line rebase.🤖 Generated with Claude Code
https://claude.ai/code/session_01CiUHyyXLTo9ATdgg8eRFZJ