Skip to content

Term ooc covariance tsmm#2494

Open
122Astha wants to merge 15 commits into
apache:mainfrom
AdityaPandey2612:term-ooc-covariance-tsmm
Open

Term ooc covariance tsmm#2494
122Astha wants to merge 15 commits into
apache:mainfrom
AdityaPandey2612:term-ooc-covariance-tsmm

Conversation

@122Astha

Copy link
Copy Markdown

I added the initial OOC covariance test setup for cov(A, B). The test creates dense and sparse vector inputs, runs the covariance script once as the CP reference and once with -ooc, then compares the results.

Currently both dense and sparse OOC tests fail for the expected Week 1 reason: SystemDS generates an OOC cov instruction, but OOCInstructionParser does not support Covariance yet. The key error is: “Invalid OOC Instruction Type: Covariance”. This confirms the test-first setup is working and identifies the missing implementation/wiring.

@janniklinde

janniklinde commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Thanks for the first PR, @122Astha. I’d suggest working on the covariance implementation before opening a PR. It isn’t necessary to open PRs just to introduce failing test cases.

Please configure your IDE to use tabs instead of spaces (and remove hello.dml).

@codecov

codecov Bot commented Jun 28, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 85.48387% with 18 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.60%. Comparing base (88c26e2) to head (6a93333).
⚠️ Report is 34 commits behind head on main.

Files with missing lines Patch % Lines
...ime/instructions/ooc/CovarianceOOCInstruction.java 82.60% 5 Missing and 3 partials ⚠️
.../instructions/ooc/CentralMomentOOCInstruction.java 82.35% 4 Missing and 2 partials ⚠️
...s/runtime/instructions/ooc/TSMMOOCInstruction.java 90.47% 1 Missing and 3 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2494      +/-   ##
============================================
+ Coverage     71.37%   71.60%   +0.22%     
- Complexity    48749    49178     +429     
============================================
  Files          1571     1576       +5     
  Lines        188912   189988    +1076     
  Branches      37067    37266     +199     
============================================
+ Hits         134845   136042    +1197     
+ Misses        43601    43462     -139     
- Partials      10466    10484      +18     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

4 participants