Skip to content

[SYSTEMDS-3681] Add stepGLM builtin function.#2523

Open
Bruno-Ignaz wants to merge 13 commits into
apache:mainfrom
Bruno-Ignaz:main
Open

[SYSTEMDS-3681] Add stepGLM builtin function.#2523
Bruno-Ignaz wants to merge 13 commits into
apache:mainfrom
Bruno-Ignaz:main

Conversation

@Bruno-Ignaz

Copy link
Copy Markdown

Hi,
This is a homework pull-requests for the course AMLs at TUB.
This is also my first pull-request :)

I refactored ./scripts/algorithm/StepGLM.dml into a importable function.

  • Over 900 lines of code removed
  • Replacement of global variables with function parameters
  • Replacement of custom GLM solver glm_fit with adapter that uses the builtin solver m_gml from ./scripts/builtin/gml.dml
  • Rewrite of the AIC calculation.

The probit inverse link function is now approximated (AIC calculation):

"it does not matter much whether one uses a probit model or a logit model, except in cases where data are heavily concentrated in the tails" (page 1487 in [1])

Additionally:

  • ./scripts/algorithms/TestBuiltinStepGLM.dml performs two checks for function output.

Sources

[1]: Takeshi, Qualitative Response Models: A Survey (1981)

@codecov

codecov Bot commented Jun 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.63%. Comparing base (b150d8e) to head (c341063).
⚠️ Report is 40 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2523      +/-   ##
============================================
+ Coverage     71.38%   71.63%   +0.24%     
- Complexity    48753    49269     +516     
============================================
  Files          1571     1579       +8     
  Lines        188912   190287    +1375     
  Branches      37067    37319     +252     
============================================
+ Hits         134857   136314    +1457     
+ Misses        43593    43464     -129     
- Partials      10462    10509      +47     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

1 participant