use correct error key for out-of-range hex escape in RegexParser#68
Open
aizu-m wants to merge 1 commit into
Open
use correct error key for out-of-range hex escape in RegexParser#68aizu-m wants to merge 1 commit into
aizu-m wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turned up while feeding the engine out-of-range escapes through the public RegularExpression API. A
\vescape reads six hex digits; when the value is above U+10FFFF the parser means to reject it, but the key handed toex()isparser.descappe.4, which is not in message.properties. The real key isparser.descape.4.ex()looks the key up withResourceBundle.getString, so the lookup throws MissingResourceException rather than the ParseException the rest of the parser raises.So
\v110000and\vFFFFFFleave the parser as MissingResourceException instead of a clean ParseException. The\x{...}branch just above reports the same overflow correctly viaparser.descape.4, which is what flagged the typo.One character on the key. Regression test sits next to the quantifier-overflow one.