ADFA-5361 docs(adr): say why the WebView User-Agent is read and not pinned - #512
Merged
Conversation
…inned The idea of setting our own suffix so the value is ours came up twice, independently, within one review. It does not hold: getUserAgentString() and the header the WebView sends are the same WebSettings, so there is nothing to pin, and setting one would add a string to maintain plus an "append, never replace" rule in exchange for protection against a drift the platform does not permit. It also would not close the failure it appears to address — a session rejected for any other reason still leaves a silent guest — for which the answer is verifying identity after load, not hardening the input. Recorded so the next reader does not re-derive it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The idea of setting our own suffix so the value is ours came up twice, independently, within one review. It does not hold: getUserAgentString() and the header the WebView sends are the same WebSettings, so there is nothing to pin, and setting one would add a string to maintain plus an "append, never replace" rule in exchange for protection against a drift the platform does not permit. It also would not close the failure it appears to address — a session rejected for any other reason still leaves a silent guest — for which the answer is verifying identity after load, not hardening the input.
Recorded so the next reader does not re-derive it.