ADFA-5270 | Adopt shared secret store, fix terminal-tool dedup, and cover MCP flows - #80
Open
jatezzz wants to merge 1 commit into
Open
ADFA-5270 | Adopt shared secret store, fix terminal-tool dedup, and cover MCP flows#80jatezzz wants to merge 1 commit into
jatezzz wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
jatezzz
requested review from
a team,
Daniel-ADFA,
dara-abijo-adfa and
itsaky-adfa
August 28, 2026 21:16
jatezzz
force-pushed
the
refactor/ADFA-5270-adopt-shared-secret-store
branch
from
August 31, 2026 15:03
e572fe4 to
04bc7bf
Compare
Also switches ChatViewModel's terminal-tool dedup to isTerminalToolName and adds JVM coverage for MCP keep-alive, the McpServerStore lock and McpPlugin scope cancellation.
jatezzz
force-pushed
the
refactor/ADFA-5270-adopt-shared-secret-store
branch
from
August 31, 2026 18:40
04bc7bf to
af606a7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses duplicated cryptography logic, fixes an agent loop bug, and improves test coverage:
ai-agent-mcp,ai-agent-gemini, andai-agent-openaito the host'sKeystoreSecretStore. The duplicateAndroidKeyStorereferences have been removed, andplugin.min_ide_versionis bumped to26.35. Each plugin retains its existing distinct alias so previously stored credentials migrate seamlessly.it.name == RESPOND_TOOLcheck inChatViewModelwith theisTerminalToolNamehelper, ensuring backend variations like "Respond" are properly filtered out and the duplicate-turn check matches correctly.McpSessionLifecycleTest),McpServerStorepreferences lock, andMcpPluginscope cancellation. Corrects theMcpServerStore.hasHeadersKDoc to accurately reflect its boolean return type.Details
libs/.Screen_Recording_20260825_162828_Code.on.the.Go.mp4
Ticket
ADFA-5270
Parent: ADFA-5255
Observation
By eliminating the redundant AES/GCM implementations, we prevent further code drift between the three AI plugins. The deduplication fix will prevent agents from getting stuck in terminal tool loops.