QUIC: don't prefetch a datagram batch when sending on a non-current path - #194
Merged
Merged
Conversation
Sending on a path other than the current one carries only that path's items (PATH_CHALLENGE, PATH_RESPONSE) and builds a single packet, but it fetched a batch of up to 10 datagrams from the current path whenever stream data was queued. The unused datagrams were released without being finalized, which traps in Frame.deinit. Leave the batch empty so buildSinglePacketForKeyState fetches one datagram from the path being sent on.
agnosticdev
approved these changes
Oct 1, 2026
tfpauly
approved these changes
Oct 1, 2026
rpaulo
approved these changes
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sending on a path other than the current one carries only that path's items (PATH_CHALLENGE, PATH_RESPONSE) and builds a single packet, but it fetched a batch from the current path whenever stream data was queued. The unused datagrams were released without being finalized. But we don't need to fetch a batch here. Leave the batch empty so buildSinglePacketForKeyState fetches one datagram from the path being sent on.