Conversation
- Convert `CongestionControl` from an enum into a struct holding all controllers, dispatching through `CongestionControlOperation` and `CongestionControlQuery` protocols to avoid per-call copy-and-reassign. - Add placeholder initializers to each controller and make the type non-Optional on `QUICPath`, simplifying all call sites. - Generalize `inherit(from:)` to accept any `CongestionControlProtocol` and centralize re-creation and handoff via `reset` and `switchTo`. - Add `CongestionControlTests` covering dispatch, switching, and reset.
Contributor
Author
|
This is a different way of doing #204 We should consider both approaches and find out which one we want to live with. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CongestionControlfrom an enum into a struct holding allcontrollers, dispatching through
CongestionControlOperationandCongestionControlQueryprotocols to avoid per-call copy-and-reassign.non-Optional on
QUICPath, simplifying all call sites.inherit(from:)to accept anyCongestionControlProtocoland centralize re-creation and handoff via
resetandswitchTo.CongestionControlTestscovering dispatch, switching, and reset.