Stop the probes when AppSignal stops - #279
Merged
Merged
Conversation
Starting AppSignal starts the minutely probe thread, and stopping it leaves that thread running. The probes keep calling user functions and keep recording metrics after the application asked AppSignal to stop. Stopping the probes joins their thread, which cannot finish until the probe it is running returns, so the join is bounded and warns when it gives up. The probes stop before the OpenTelemetry providers are shut down, because they report through the metric helpers and a probe running after the meter provider is gone has nowhere to put its metrics.
|
Hi @unflxw, We've found some issues with your Pull Request.
|
unflxw
marked this pull request as ready for review
August 27, 2026 16:26
|
Hi @unflxw, We've found new issues for this Pull Request. Please see the main comment on this issue for a list of all current warnings. This comment will not be updated to reflect resolved warnings.
|
unflxw
added a commit
that referenced
this pull request
Aug 28, 2026
Starting AppSignal starts the minutely probe thread, and stopping it leaves that thread running. The probes keep calling user functions and keep recording metrics after the application asked AppSignal to stop. Stopping the probes joins their thread, which cannot finish until the probe it is running returns, so the join is bounded and warns when it gives up. The probes stop before the OpenTelemetry providers are shut down, because they report through the metric helpers and a probe running after the meter provider is gone has nowhere to put its metrics.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Starting AppSignal starts the minutely probe thread, and stopping it
leaves that thread running. The probes keep calling user functions and
keep recording metrics after the application asked AppSignal to stop.
Stopping the probes joins their thread, which cannot finish until the
probe it is running returns, so the join is bounded and warns when it
gives up. The probes stop before the OpenTelemetry providers are shut
down, because they report through the metric helpers and a probe
running after the meter provider is gone has nowhere to put its
metrics.