Send collector data through the CA file and proxy - #281
Merged
Conversation
|
Hi @unflxw, We've found some issues with your Pull Request.
|
unflxw
marked this pull request as ready for review
August 27, 2026 16:52
|
Hi @unflxw, We've found new issues for this Pull Request. Please see the main comment on this issue for a list of all current warnings. This comment will not be updated to reflect resolved warnings.
|
Contributor
Author
|
Merging this one because it's fairly straight-forward. The Ruby one requires monkey-patching the OTLP exporters, so it's trickier and I'd like a review on that. |
The OpenTelemetry exporters are built with an endpoint and nothing else, so the `ca_file_path` and `http_proxy` options do not reach the data sent to a collector. They do reach the data the agent sends, so a proxy or a private certificate authority works in one mode and not the other. Each exporter now takes the certificate file, and a session carrying the proxy when one is configured. They get a session each rather than sharing one, because each exports from its own thread and a session is not thread safe. Without a proxy they are left to build their own session, which keeps the exporters' own credential provider working.
unflxw
force-pushed
the
send-ca-file-and-proxy-to-collector
branch
from
August 27, 2026 17:06
d6a988a to
13a8a2a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The OpenTelemetry exporters are built with an endpoint and nothing
else, so the
ca_file_pathandhttp_proxyoptions do not reach thedata sent to a collector. They do reach the data the agent sends, so a
proxy or a private certificate authority works in one mode and not the
other.
Each exporter now takes the certificate file, and a session carrying
the proxy when one is configured. They get a session each rather than
sharing one, because each exports from its own thread and a session is
not thread safe. Without a proxy they are left to build their own
session, which keeps the exporters' own credential provider working.
The same change for AppSignal for Ruby is in appsignal/appsignal-ruby#1596.