Alignment options - #82
Open
siseval wants to merge 4 commits into
Open
Conversation
areofyl
requested changes
Aug 28, 2026
areofyl
left a comment
Owner
There was a problem hiding this comment.
The feature makes sense but the code needs a few fixes before merging:
- Style: 2-space indent, K&R braces (opening brace on same line),
char *notchar*. This is just to match the rest of the codebase - Add static to
get_alignment_padding() - Add
continue;after the config parsing blocks so they don't fall through - Move the
get_term_size()call out of the per-frame loop. Compute alignment once and recompute onSIGWINCH
Author
|
Think I've cleaned up all the inconsistent syntax. Added continues in both config parse blocks. Terminal size is now calculated once on startup, and in the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added enums for vertical and horizontal alignment, and expanded the config loader to find fields v_alignment and h_alignment. I also added these to the README.
v_alignment=bottom does leave a slightly bigger gap at the bottom than v_alignment=top does on top, as render_height over-estimates the height of the full render.
Otherwise seems to work :)