Skip to content

make precompileModules opt-in via precompile option #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
johnchandlerburnham wants to merge 1 commit into
base: main
Choose a base branch
from
Open

make precompileModules opt-in via precompile option #47

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion lakefile.lean
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,15 @@ open Lake DSL

package Blake3

/- Passing the `precompile` option (e.g. `options = {precompile = "on"}` on the
downstream `[[require]]`, or `with NameMap.empty.insert `precompile "on"` in a
`lakefile.lean` require) precompiles these libs so the C/Rust FFI symbols are
auto-loaded into elaborating processes (batch builds and language-server
workers) — needed by consumers that call Blake3 in `#eval` at elaboration
time. Off by default: without the option, behavior is unchanged. -/
@[default_target]
lean_lib Blake3
lean_lib Blake3 where
precompileModules := (get_config? precompile).isSome

@[test_driver]
lean_exe Blake3Test
Expand Down Expand Up @@ -78,6 +85,7 @@ target blake3_c pkg : System.FilePath := do
buildStaticLib (pkg.staticLibDir / name) oFileJobs

lean_lib Blake3C where
precompileModules := (get_config? precompile).isSome
roots := #[`Blake3.C]
moreLinkObjs := #[blake3_c]

Expand All @@ -88,6 +96,7 @@ target blake3_rs pkg : System.FilePath := do
inputBinFile $ pkg.dir / "rust" / "target" / "release" / libName

lean_lib Blake3Rust where
precompileModules := (get_config? precompile).isSome
roots := #[`Blake3.Rust]
moreLinkObjs := #[blake3_rs]

Expand Down