fix logout - #653
Merged
Merged
fix logout#653
Conversation
The logout link is now a form in the header, so the data-entry validator was serializing it (just a CSRF token) instead of the upload form, and every validation failed with "Error #20". Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
EC.staleness_of returns a callable and never raises, so wrapping it in _ensure_eventually_asserts waited for nothing. The test then read the old page's validation message before the navigation happened. Use WebDriverWait so it actually waits for the reload. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #653 +/- ##
==========================================
- Coverage 96.10% 96.08% -0.02%
==========================================
Files 132 132
Lines 6363 6364 +1
==========================================
Hits 6115 6115
- Misses 248 249 +1
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And some unit test flakiness fixes